Commit 7184aef9 authored by Lam Thai's avatar Lam Thai Committed by Andrii Nakryiko
Browse files

bpftool: Fix a wrong type cast in btf_dumper_int 



When `data` points to a boolean value, casting it to `int *` is problematic
and could lead to a wrong value being passed to `jsonw_bool`. Change the
cast to `bool *` instead.

Fixes: b12d6ec0 ("bpf: btf: add btf print functionality")
Signed-off-by: default avatarLam Thai <lamthai@arista.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Reviewed-by: default avatarQuentin Monnet <quentin@isovalent.com>
Acked-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20220824225859.9038-1-lamthai@arista.com
parent eef3c3d3

tools/bpf/bpftool/btf_dumper.c

+1 −1
Original line number Diff line number Diff line
@@ -452,7 +452,7 @@ static int btf_dumper_int(const struct btf_type *t, __u8 bit_offset, 
					     *(char *)data);

		break;

	case BTF_INT_BOOL:

		jsonw_bool(jw, *(int *)data);

		jsonw_bool(jw, *(bool *)data);

		break;

	default:

		/* shouldn't happen */