Commit 7183c37f authored by Herve Codina's avatar Herve Codina Committed by Greg Kroah-Hartman
Browse files

serial: cpm_uart: Fix a COMPILE_TEST dependency 



In a COMPILE_TEST configuration, the cpm_uart driver uses symbols from
the cpm_uart_cpm2.c file. This file is compiled only when CONFIG_CPM2 is
set.

Without this dependency, the linker fails with some missing symbols for
COMPILE_TEST configuration that needs SERIAL_CPM without enabling CPM2.

This lead to:
  depends on CPM2 || CPM1 || (PPC32 && CPM2 && COMPILE_TEST)

This dependency does not make sense anymore and can be simplified
removing all the COMPILE_TEST part.

Signed-off-by: default avatarHerve Codina <herve.codina@bootlin.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/
Fixes: e3e7b13b ("serial: allow COMPILE_TEST for some drivers")
Cc: stable <stable@kernel.org>
Link: https://lore.kernel.org/r/20230523085902.75837-3-herve.codina@bootlin.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 192d43e9

drivers/tty/serial/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -762,7 +762,7 @@ config SERIAL_PMACZILOG_CONSOLE 


config SERIAL_CPM

	tristate "CPM SCC/SMC serial port support"

	depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST)

	depends on CPM2 || CPM1

	select SERIAL_CORE

	help

	  This driver supports the SCC and SMC serial ports on Motorola

drivers/tty/serial/cpm_uart/cpm_uart.h

+0 −2
Original line number Diff line number Diff line
@@ -19,8 +19,6 @@ struct gpio_desc; 
#include "cpm_uart_cpm2.h"

#elif defined(CONFIG_CPM1)

#include "cpm_uart_cpm1.h"

#elif defined(CONFIG_COMPILE_TEST)

#include "cpm_uart_cpm2.h"

#endif



#define SERIAL_CPM_MAJOR	204