Commit 71839a64 authored by Martin Kaiser's avatar Martin Kaiser Committed by Herbert Xu
Browse files

hwrng: ingenic - don't disable the rng in ingenic_trng_remove 



There's no need to disable the rng in ingenic_trng_remove.

The driver's init function sets the CFG_GEN_EN bit to enable the
rng. The cleanup function clears CFG_GEN_EN to revert this.

The remove function calls hwrng_unregister. If the ingenic-trng is not
the current rng at this point, CFG_GEN_EN has already been cleared. If
the ingenic-trng is the current rng, drop_current_rng will call the
cleanup function.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 6257490b

drivers/char/hw_random/ingenic-trng.c

+0 −5
Original line number Diff line number Diff line
@@ -111,14 +111,9 @@ static int ingenic_trng_probe(struct platform_device *pdev) 
static int ingenic_trng_remove(struct platform_device *pdev)

{

	struct ingenic_trng *trng = platform_get_drvdata(pdev);

	unsigned int ctrl;



	hwrng_unregister(&trng->rng);



	ctrl = readl(trng->base + TRNG_REG_CFG_OFFSET);

	ctrl &= ~CFG_GEN_EN;

	writel(ctrl, trng->base + TRNG_REG_CFG_OFFSET);



	return 0;

}