Commit 712fe4c8 authored by Magnus Damm's avatar Magnus Damm Committed by Greg Kroah-Hartman
Browse files

serial: sh-sci: Remove BREAK/FRAME/PARITY/OVERRUN printouts 



Update the SCIF serial driver to remove printouts for break, frame, parity
and overrun errors. This reduces the amount of console printouts generated
by the defconfig kernel on R-Car Gen3 for certain use cases. To retrieve
more information about such errors the user may inspect counters. Also these
errors are fed into the TTY layer for further application specific handling.

Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarMagnus Damm <damm+renesas@opensource.se>
Link: https://lore.kernel.org/r/163884254093.18109.2982470198301927679.sendpatchset@octo


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 46dacba8

drivers/tty/serial/sh-sci.c

+0 −12
Original line number Diff line number Diff line
@@ -896,11 +896,9 @@ static void sci_receive_chars(struct uart_port *port) 
				if (status & SCxSR_FER(port)) {

					flag = TTY_FRAME;

					port->icount.frame++;

					dev_notice(port->dev, "frame error\n");

				} else if (status & SCxSR_PER(port)) {

					flag = TTY_PARITY;

					port->icount.parity++;

					dev_notice(port->dev, "parity error\n");

				} else

					flag = TTY_NORMAL;
@@ -940,8 +938,6 @@ static int sci_handle_errors(struct uart_port *port) 
		/* overrun error */

		if (tty_insert_flip_char(tport, 0, TTY_OVERRUN))

			copied++;



		dev_notice(port->dev, "overrun error\n");

	}



	if (status & SCxSR_FER(port)) {
@@ -950,8 +946,6 @@ static int sci_handle_errors(struct uart_port *port) 


		if (tty_insert_flip_char(tport, 0, TTY_FRAME))

			copied++;



		dev_notice(port->dev, "frame error\n");

	}



	if (status & SCxSR_PER(port)) {
@@ -960,8 +954,6 @@ static int sci_handle_errors(struct uart_port *port) 


		if (tty_insert_flip_char(tport, 0, TTY_PARITY))

			copied++;



		dev_notice(port->dev, "parity error\n");

	}



	if (copied)
@@ -991,8 +983,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port) 


		tty_insert_flip_char(tport, 0, TTY_OVERRUN);

		tty_flip_buffer_push(tport);



		dev_dbg(port->dev, "overrun error\n");

		copied++;

	}
@@ -1014,8 +1004,6 @@ static int sci_handle_breaks(struct uart_port *port) 
		/* Notify of BREAK */

		if (tty_insert_flip_char(tport, 0, TTY_BREAK))

			copied++;



		dev_dbg(port->dev, "BREAK detected\n");

	}



	if (copied)