Commit 7128af87 authored by Sudeep Holla's avatar Sudeep Holla
Browse files

ACPI: Remove the unused find_acpi_cpu_cache_topology() 

The sole user of this find_acpi_cpu_cache_topology() was arm64 topology
which is now consolidated into the generic arch_topology without the need
of this function.

Drop the unused function find_acpi_cpu_cache_topology().

Link: https://lore.kernel.org/r/20220704101605.1318280-22-sudeep.holla@arm.com


Cc: Rafael J. Wysocki <rafael@kernel.org>
Reported-by: default avatarIonela Voinescu <ionela.voinescu@arm.com>
Tested-by: default avatarConor Dooley <conor.dooley@microchip.com>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 00e66e37

drivers/acpi/pptt.c

+0 −37
Original line number Diff line number Diff line
@@ -691,43 +691,6 @@ int find_acpi_cpu_topology(unsigned int cpu, int level) 
	return find_acpi_cpu_topology_tag(cpu, level, 0);

}



/**

 * find_acpi_cpu_cache_topology() - Determine a unique cache topology value

 * @cpu: Kernel logical CPU number

 * @level: The cache level for which we would like a unique ID

 *

 * Determine a unique ID for each unified cache in the system

 *

 * Return: -ENOENT if the PPTT doesn't exist, or the CPU cannot be found.

 * Otherwise returns a value which represents a unique topological feature.

 */

int find_acpi_cpu_cache_topology(unsigned int cpu, int level)

{

	struct acpi_table_header *table;

	struct acpi_pptt_cache *found_cache;

	acpi_status status;

	u32 acpi_cpu_id = get_acpi_id_for_cpu(cpu);

	struct acpi_pptt_processor *cpu_node = NULL;

	int ret = -1;



	status = acpi_get_table(ACPI_SIG_PPTT, 0, &table);

	if (ACPI_FAILURE(status)) {

		acpi_pptt_warn_missing();

		return -ENOENT;

	}



	found_cache = acpi_find_cache_node(table, acpi_cpu_id,

					   CACHE_TYPE_UNIFIED,

					   level,

					   &cpu_node);

	if (found_cache)

		ret = ACPI_PTR_DIFF(cpu_node, table);



	acpi_put_table(table);



	return ret;

}



/**

 * find_acpi_cpu_topology_package() - Determine a unique CPU package value

 * @cpu: Kernel logical CPU number

include/linux/acpi.h

+0 −5
Original line number Diff line number Diff line
@@ -1429,7 +1429,6 @@ int find_acpi_cpu_topology(unsigned int cpu, int level); 
int find_acpi_cpu_topology_cluster(unsigned int cpu);

int find_acpi_cpu_topology_package(unsigned int cpu);

int find_acpi_cpu_topology_hetero_id(unsigned int cpu);

int find_acpi_cpu_cache_topology(unsigned int cpu, int level);

#else

static inline int acpi_pptt_cpu_is_thread(unsigned int cpu)

{
@@ -1451,10 +1450,6 @@ static inline int find_acpi_cpu_topology_hetero_id(unsigned int cpu) 
{

	return -EINVAL;

}

static inline int find_acpi_cpu_cache_topology(unsigned int cpu, int level)

{

	return -EINVAL;

}

#endif



#ifdef CONFIG_ACPI_PCC