Commit 70f8019e authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: Remove redundant filter_dev arg from parse_tc_fdb_actions() 



filter_dev is saved in parse_attr. and being used in other cases from
there. use it also for the leftover case.

Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 696ceeb2

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+3 −4
Original line number Diff line number Diff line
@@ -3707,8 +3707,7 @@ static int verify_uplink_forwarding(struct mlx5e_priv *priv, 
static int parse_tc_fdb_actions(struct mlx5e_priv *priv,

				struct flow_action *flow_action,

				struct mlx5e_tc_flow *flow,

				struct netlink_ext_ack *extack,

				struct net_device *filter_dev)

				struct netlink_ext_ack *extack)

{

	struct pedit_headers_action hdrs[2] = {};

	struct mlx5_eswitch *esw = priv->mdev->priv.eswitch;
@@ -3773,7 +3772,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, 
						   "mpls pop supported only as first action");

				return -EOPNOTSUPP;

			}

			if (!netif_is_bareudp(filter_dev)) {

			if (!netif_is_bareudp(parse_attr->filter_dev)) {

				NL_SET_ERR_MSG_MOD(extack,

						   "mpls pop supported only on bareudp devices");

				return -EOPNOTSUPP;
@@ -4275,7 +4274,7 @@ __mlx5e_add_fdb_flow(struct mlx5e_priv *priv, 
	if (err)

		goto err_free;



	err = parse_tc_fdb_actions(priv, &rule->action, flow, extack, filter_dev);

	err = parse_tc_fdb_actions(priv, &rule->action, flow, extack);

	if (err)

		goto err_free;