Commit 70e42fea authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: fix possible double unlock when moving a directory 

Fixes: 0813299c ("ext4: Fix possible corruption when moving a directory")
Link: https://lore.kernel.org/r/5efbe1b9-ad8b-4a4f-b422-24824d2b775c@kili.mountain


Reported-by: default avatarDan Carpenter <error27@gmail.com>
Reported-by: default avatar <syzbot+0c73d1d8b952c5f3d714@syzkaller.appspotmail.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent eeac8ede

fs/ext4/namei.c

+1 −3
Original line number Diff line number Diff line
@@ -3884,11 +3884,9 @@ static int ext4_rename(struct mnt_idmap *idmap, struct inode *old_dir, 
				goto end_rename;

		}

		retval = ext4_rename_dir_prepare(handle, &old);

		if (retval) {

			inode_unlock(old.inode);

		if (retval)

			goto end_rename;

	}

	}

	/*

	 * If we're renaming a file within an inline_data dir and adding or

	 * setting the new dirent causes a conversion from inline_data to