Commit 70b0bc4c authored by Michal Luczaj's avatar Michal Luczaj Committed by Sean Christopherson
Browse files

KVM: Don't kfree(NULL) on kzalloc() failure in kvm_assign_ioeventfd_idx() 



On kzalloc() failure, taking the `goto fail` path leads to kfree(NULL).
Such no-op has no use. Move it out.

Signed-off-by: default avatarMichal Luczaj <mhal@rbox.co>
Reviewed-by: default avatarSean Christopherson <seanjc@google.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lore.kernel.org/r/20230327175457.735903-1-mhal@rbox.co


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent c9d60154

virt/kvm/eventfd.c

+1 −1
Original line number Diff line number Diff line
@@ -889,9 +889,9 @@ static int kvm_assign_ioeventfd_idx(struct kvm *kvm, 


unlock_fail:

	mutex_unlock(&kvm->slots_lock);

	kfree(p);



fail:

	kfree(p);

	eventfd_ctx_put(eventfd);



	return ret;