Commit 70ae13ab authored by Yang Li's avatar Yang Li Committed by Martin K. Petersen
Browse files

scsi: isci: Remove redundant initialization of variable 'status' 

This patch removes unneeded return variables. It fixes the following
warning detected by coccinelle:

./drivers/scsi/isci/request.c:1483:17-23: Unneeded variable: "status".
Return "SCI_SUCCESS" on line 1503
./drivers/scsi/isci/request.c:2157:17-23: Unneeded variable: "status".
Return "SCI_SUCCESS" on line 2177

Link: https://lore.kernel.org/r/1612424915-106608-1-git-send-email-yang.lee@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent bafd09f8

drivers/scsi/isci/request.c

+2 −6
Original line number Diff line number Diff line
@@ -1480,8 +1480,6 @@ static enum sci_status 
stp_request_pio_await_h2d_completion_tc_event(struct isci_request *ireq,

					      u32 completion_code)

{

	enum sci_status status = SCI_SUCCESS;



	switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {

	case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_GOOD):

		ireq->scu_status = SCU_TASK_DONE_GOOD;
@@ -1500,7 +1498,7 @@ stp_request_pio_await_h2d_completion_tc_event(struct isci_request *ireq, 
		break;

	}



	return status;

	return SCI_SUCCESS;

}



static enum sci_status
@@ -2152,8 +2150,6 @@ static enum sci_status stp_request_udma_await_tc_event(struct isci_request *ireq 
static enum sci_status atapi_raw_completion(struct isci_request *ireq, u32 completion_code,

						  enum sci_base_request_states next)

{

	enum sci_status status = SCI_SUCCESS;



	switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {

	case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_GOOD):

		ireq->scu_status = SCU_TASK_DONE_GOOD;
@@ -2172,7 +2168,7 @@ static enum sci_status atapi_raw_completion(struct isci_request *ireq, u32 compl 
		break;

	}



	return status;

	return SCI_SUCCESS;

}



static enum sci_status atapi_data_tc_completion_handler(struct isci_request *ireq,