Commit 70a4f962 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Xiangwei Li
Browse files

net: dsa: mv88e6xxx: Fix refcount leak in mv88e6xxx_mdios_register 

stable inclusion
from stable-v4.19.247
commit 86c3c5f8e4bd1325e24f6fba9017cade29933377
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBP3U4
CVE: CVE-2022-49367

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=86c3c5f8e4bd1325e24f6fba9017cade29933377



--------------------------------

[ Upstream commit 02ded5a1 ]

of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.

mv88e6xxx_mdio_register() pass the device node to of_mdiobus_register().
We don't need the device node after it.

Add missing of_node_put() to avoid refcount leak.

Fixes: a3c53be5 ("net: dsa: mv88e6xxx: Support multiple MDIO busses")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarMarek Behún <kabel@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarXiangwei Li <liwei728@huawei.com>
parent df354167

drivers/net/dsa/mv88e6xxx/chip.c

+1 −0
Original line number Diff line number Diff line
@@ -2778,6 +2778,7 @@ static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip, 
	 */

	child = of_get_child_by_name(np, "mdio");

	err = mv88e6xxx_mdio_register(chip, child, false);

	of_node_put(child);

	if (err)

		return err;