Commit 70a3288a authored by John Keeping's avatar John Keeping Committed by Greg Kroah-Hartman
Browse files

usb: gadget: f_hid: fix refcount leak on error path 



When failing to allocate report_desc, opts->refcnt has already been
incremented so it needs to be decremented to avoid leaving the options
structure permanently locked.

Fixes: 21a9476a ("usb: gadget: hid: add configfs support")
Tested-by: default avatarLee Jones <lee@kernel.org>
Reviewed-by: default avatarAndrzej Pietrasiewicz <andrzej.p@collabora.com>
Reviewed-by: default avatarLee Jones <lee@kernel.org>
Signed-off-by: default avatarJohn Keeping <john@metanate.com>
Link: https://lore.kernel.org/r/20221122123523.3068034-3-john@metanate.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 89ff3dfa

drivers/usb/gadget/function/f_hid.c

+1 −0
Original line number Diff line number Diff line
@@ -1292,6 +1292,7 @@ static struct usb_function *hidg_alloc(struct usb_function_instance *fi) 
						 GFP_KERNEL);

		if (!hidg->report_desc) {

			put_device(&hidg->dev);

			--opts->refcnt;

			mutex_unlock(&opts->lock);

			return ERR_PTR(-ENOMEM);

		}