Commit 7089a93c authored by Peng Ma's avatar Peng Ma Committed by sanglipeng1
Browse files

dmaengine: fsl-qdma: fix SoC may hang on 16 byte unaligned read 

stable inclusion
from stable-v5.10.212
commit bb3a06e9b9a30e33d96aadc0e077be095a4f8580
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAGOP2

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=bb3a06e9b9a30e33d96aadc0e077be095a4f8580



--------------------------------

commit 9d739bccf261dd93ec1babf82f5c5d71dd4caa3e upstream.

There is chip (ls1028a) errata:

The SoC may hang on 16 byte unaligned read transactions by QDMA.

Unaligned read transactions initiated by QDMA may stall in the NOC
(Network On-Chip), causing a deadlock condition. Stalled transactions will
trigger completion timeouts in PCIe controller.

Workaround:
Enable prefetch by setting the source descriptor prefetchable bit
( SD[PF] = 1 ).

Implement this workaround.

Cc: stable@vger.kernel.org
Fixes: b092529e ("dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs")
Signed-off-by: default avatarPeng Ma <peng.ma@nxp.com>
Signed-off-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20240201215007.439503-1-Frank.Li@nxp.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarsanglipeng1 <sanglipeng1@jd.com>
parent 174dad40

drivers/dma/fsl-qdma.c

+3 −1
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ 
#define FSL_QDMA_CMD_WTHROTL_OFFSET	20

#define FSL_QDMA_CMD_DSEN_OFFSET	19

#define FSL_QDMA_CMD_LWC_OFFSET		16

#define FSL_QDMA_CMD_PF			BIT(17)



/* Field definition for Descriptor status */

#define QDMA_CCDF_STATUS_RTE		BIT(5)
@@ -384,7 +385,8 @@ static void fsl_qdma_comp_fill_memcpy(struct fsl_qdma_comp *fsl_comp, 
	qdma_csgf_set_f(csgf_dest, len);

	/* Descriptor Buffer */

	cmd = cpu_to_le32(FSL_QDMA_CMD_RWTTYPE <<

			  FSL_QDMA_CMD_RWTTYPE_OFFSET);

			  FSL_QDMA_CMD_RWTTYPE_OFFSET) |

			  FSL_QDMA_CMD_PF;

	sdf->data = QDMA_SDDF_CMD(cmd);



	cmd = cpu_to_le32(FSL_QDMA_CMD_RWTTYPE <<