Commit 70618035 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Jonathan Cameron
Browse files

iio: hid-sensors: select IIO_TRIGGERED_BUFFER under HID_SENSOR_IIO_TRIGGER 



During commit 067fda1c ("iio: hid-sensors: move triggered buffer
setup into hid_sensor_setup_trigger"), the
iio_triggered_buffer_{setup,cleanup}() functions got moved under the
hid-sensor-trigger module.

The above change works fine, if any of the sensors get built. However, when
only the common hid-sensor-trigger module gets built (and none of the
drivers), then the IIO_TRIGGERED_BUFFER symbol isn't selected/enforced.

Previously, each driver would enforce/select the IIO_TRIGGERED_BUFFER
symbol. With this change the HID_SENSOR_IIO_TRIGGER (for the
hid-sensor-trigger module) will enforce that IIO_TRIGGERED_BUFFER gets
selected.

All HID sensor drivers select the HID_SENSOR_IIO_TRIGGER symbol. So, this
change removes the IIO_TRIGGERED_BUFFER enforcement from each driver.

Fixes: 067fda1c ("iio: hid-sensors: move triggered buffer setup into hid_sensor_setup_trigger")
Reported-by: default avatarThomas Deutschmann <whissi@gentoo.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarAlexandru Ardelean <aardelean@deviqon.com>
Acked-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://lore.kernel.org/r/20210414084955.260117-1-aardelean@deviqon.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent a2fa9242

drivers/iio/accel/Kconfig

+0 −1
Original line number Diff line number Diff line
@@ -229,7 +229,6 @@ config DMARD10 
config HID_SENSOR_ACCEL_3D

	depends on HID_SENSOR_HUB

	select IIO_BUFFER

	select IIO_TRIGGERED_BUFFER

	select HID_SENSOR_IIO_COMMON

	select HID_SENSOR_IIO_TRIGGER

	tristate "HID Accelerometers 3D"

drivers/iio/common/hid-sensors/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ config HID_SENSOR_IIO_TRIGGER 
	tristate "Common module (trigger) for all HID Sensor IIO drivers"

	depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON && IIO_BUFFER

	select IIO_TRIGGER

	select IIO_TRIGGERED_BUFFER

	help

	  Say yes here to build trigger support for HID sensors.

	  Triggers will be send if all requested attributes were read.

drivers/iio/gyro/Kconfig

+0 −1
Original line number Diff line number Diff line
@@ -111,7 +111,6 @@ config FXAS21002C_SPI 
config HID_SENSOR_GYRO_3D

	depends on HID_SENSOR_HUB

	select IIO_BUFFER

	select IIO_TRIGGERED_BUFFER

	select HID_SENSOR_IIO_COMMON

	select HID_SENSOR_IIO_TRIGGER

	tristate "HID Gyroscope 3D"

drivers/iio/humidity/Kconfig

+0 −1
Original line number Diff line number Diff line
@@ -52,7 +52,6 @@ config HID_SENSOR_HUMIDITY 
	tristate "HID Environmental humidity sensor"

	depends on HID_SENSOR_HUB

	select IIO_BUFFER

	select IIO_TRIGGERED_BUFFER

	select HID_SENSOR_IIO_COMMON

	select HID_SENSOR_IIO_TRIGGER

	help

drivers/iio/light/Kconfig

+0 −2
Original line number Diff line number Diff line
@@ -256,7 +256,6 @@ config ISL29125 
config HID_SENSOR_ALS

	depends on HID_SENSOR_HUB

	select IIO_BUFFER

	select IIO_TRIGGERED_BUFFER

	select HID_SENSOR_IIO_COMMON

	select HID_SENSOR_IIO_TRIGGER

	tristate "HID ALS"
@@ -270,7 +269,6 @@ config HID_SENSOR_ALS 
config HID_SENSOR_PROX

	depends on HID_SENSOR_HUB

	select IIO_BUFFER

	select IIO_TRIGGERED_BUFFER

	select HID_SENSOR_IIO_COMMON

	select HID_SENSOR_IIO_TRIGGER

	tristate "HID PROX"