Commit 70513e1d authored by YueHaibing's avatar YueHaibing Committed by Herbert Xu
Browse files

crypto: aspeed - Fix check for platform_get_irq() errors 



The platform_get_irq() function returns negative on error and
positive non-zero values on success. It never returns zero, but if it
did then treat that as a success.

Also remove redundant dev_err() print as platform_get_irq() already
prints an error.

Fixes: 108713a7 ("crypto: aspeed - Add HACE hash driver")
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Reviewed-by: default avatarNeal Liu <neal_liu@aspeedtech.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 4a209078

drivers/crypto/aspeed/aspeed-hace.c

+1 −3
Original line number Diff line number Diff line
@@ -130,10 +130,8 @@ static int aspeed_hace_probe(struct platform_device *pdev) 


	/* Get irq number and register it */

	hace_dev->irq = platform_get_irq(pdev, 0);

	if (!hace_dev->irq) {

		dev_err(&pdev->dev, "Failed to get interrupt\n");

	if (hace_dev->irq < 0)

		return -ENXIO;

	}



	rc = devm_request_irq(&pdev->dev, hace_dev->irq, aspeed_hace_irq, 0,

			      dev_name(&pdev->dev), hace_dev);