Commit 6fe240bc authored Mar 26, 2023 by Chaitanya Kulkarni Committed by Christoph Hellwig Apr 13, 2023

nvmet-tcp: validate idle poll modparam value



The module parameter idle_poll_period_usecs is passed to the function
usecs_to_jiffies() which has following prototype and expect
idle_poll_period_usecs arg type to be unsigned int:-

unsigned long usecs_to_jiffies(const unsigned int u);

Use similar module parameter validation callback as previous patch.

Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 44aef3b8

drivers/nvme/target/tcp.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -61,9 +61,10 @@ MODULE_PARM_DESC(so_priority, "nvmet tcp socket optimize priority: Default 0");
		* using advanced interrupt moderation techniques.
		*/
		static int idle_poll_period_usecs;
		module_param(idle_poll_period_usecs, int, 0644);
		device_param_cb(idle_poll_period_usecs, &set_param_ops,
		&idle_poll_period_usecs, 0644);
		MODULE_PARM_DESC(idle_poll_period_usecs,
		"nvmet tcp io_work poll till idle time period in usecs");
		"nvmet tcp io_work poll till idle time period in usecs: Default 0");

		#define NVMET_TCP_RECV_BUDGET 8
		#define NVMET_TCP_SEND_BUDGET 8