Commit 6fd2c68d authored by Haiyang Zhang's avatar Haiyang Zhang Committed by Jakub Kicinski
Browse files

net: mana: Add rmb after checking owner bits 



Per GDMA spec, rmb is necessary after checking owner_bits, before
reading EQ or CQ entries.

Add rmb in these two places to comply with the specs.

Cc: stable@vger.kernel.org
Fixes: ca9c54d2 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
Reported-by: default avatarSinan Kaya <Sinan.Kaya@microsoft.com>
Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: default avatarDexuan Cui <decui@microsoft.com>
Link: https://lore.kernel.org/r/1662928805-15861-1-git-send-email-haiyangz@microsoft.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6fb2dbdb

drivers/net/ethernet/microsoft/mana/gdma_main.c

+10 −0
Original line number Diff line number Diff line
@@ -397,6 +397,11 @@ static void mana_gd_process_eq_events(void *arg) 
			break;

		}



		/* Per GDMA spec, rmb is necessary after checking owner_bits, before

		 * reading eqe.

		 */

		rmb();



		mana_gd_process_eqe(eq);



		eq->head++;
@@ -1134,6 +1139,11 @@ static int mana_gd_read_cqe(struct gdma_queue *cq, struct gdma_comp *comp) 
	if (WARN_ON_ONCE(owner_bits != new_bits))

		return -1;



	/* Per GDMA spec, rmb is necessary after checking owner_bits, before

	 * reading completion info

	 */

	rmb();



	comp->wq_num = cqe->cqe_info.wq_num;

	comp->is_sq = cqe->cqe_info.is_sq;

	memcpy(comp->cqe_data, cqe->cqe_data, GDMA_COMP_DATA_SIZE);