Commit 6f978a30 authored by Chunfeng Yun's avatar Chunfeng Yun Committed by Greg Kroah-Hartman
Browse files

usb: xhci-mtk: fix broken streams issue on 0.96 xHCI 



The MediaTek 0.96 xHCI controller on some platforms does not
support bulk stream even HCCPARAMS says supporting, due to MaxPSASize
is set a default value 1 by mistake, here use XHCI_BROKEN_STREAMS
quirk to fix it.

Fixes: 94a631d9 ("usb: xhci-mtk: check hcc_params after adding primary hcd")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarChunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/1616482975-17841-4-git-send-email-chunfeng.yun@mediatek.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5aef6297

drivers/usb/host/xhci-mtk.c

+9 −1
Original line number Diff line number Diff line
@@ -397,6 +397,13 @@ static void xhci_mtk_quirks(struct device *dev, struct xhci_hcd *xhci) 
	xhci->quirks |= XHCI_SPURIOUS_SUCCESS;

	if (mtk->lpm_support)

		xhci->quirks |= XHCI_LPM_SUPPORT;



	/*

	 * MTK xHCI 0.96: PSA is 1 by default even if doesn't support stream,

	 * and it's 3 when support it.

	 */

	if (xhci->hci_version < 0x100 && HCC_MAX_PSA(xhci->hcc_params) == 4)

		xhci->quirks |= XHCI_BROKEN_STREAMS;

}



/* called during probe() after chip reset completes */
@@ -548,7 +555,8 @@ static int xhci_mtk_probe(struct platform_device *pdev) 
	if (ret)

		goto put_usb3_hcd;



	if (HCC_MAX_PSA(xhci->hcc_params) >= 4)

	if (HCC_MAX_PSA(xhci->hcc_params) >= 4 &&

	    !(xhci->quirks & XHCI_BROKEN_STREAMS))

		xhci->shared_hcd->can_do_streams = 1;



	ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);