Commit 6f9223a5 authored by Steven Price's avatar Steven Price
Browse files

drm/of: free the iterator object on failure 



When bailing out due to the sanity check the iterator value needs to be
freed because the early return prevents for_each_child_of_node() from
doing the dereference itself.

Fixes: 65290075 ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Signed-off-by: default avatarSteven Price <steven.price@arm.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210714143300.20632-1-steven.price@arm.com
parent 311ac6f3

drivers/gpu/drm/drm_of.c

+3 −1
Original line number Diff line number Diff line
@@ -331,9 +331,11 @@ static int drm_of_lvds_get_remote_pixels_type( 
		 * configurations by passing the endpoints explicitly to

		 * drm_of_lvds_get_dual_link_pixel_order().

		 */

		if (!current_pt || pixels_type != current_pt)

		if (!current_pt || pixels_type != current_pt) {

			of_node_put(endpoint);

			return -EINVAL;

		}

	}



	return pixels_type;

}