Commit 6f746d48 authored by Zhen Lei's avatar Zhen Lei Committed by Greg Kroah-Hartman
Browse files

mcb: Use DEFINE_RES_MEM() helper macro and fix the end address 



Use DEFINE_RES_MEM() to save a couple of lines of code, which makes the
code a bit shorter and easier to read. The start address does not need to
appear twice.

By the way, the value of '.end' should be "start + size - 1". So the
previous writing should have omitted subtracted 1.

Fixes: acf5e051 ("MCB: add support for SC31 to mcb-lpc")
Fixes: 73edc8f7 ("mcb: Added support for LPC or non PCI based MCB carrier")
Signed-off-by: default avatarZhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210616073030.834-2-thunder.leizhen@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d02908ad

drivers/mcb/mcb-lpc.c

+2 −11
Original line number Diff line number Diff line
@@ -105,17 +105,8 @@ static int mcb_lpc_create_platform_device(const struct dmi_system_id *id) 
	return ret;

}



static struct resource sc24_fpga_resource = {

	.start = 0xe000e000,

	.end = 0xe000e000 + CHAM_HEADER_SIZE,

	.flags = IORESOURCE_MEM,

};



static struct resource sc31_fpga_resource = {

	.start = 0xf000e000,

	.end = 0xf000e000 + CHAM_HEADER_SIZE,

	.flags = IORESOURCE_MEM,

};

static struct resource sc24_fpga_resource = DEFINE_RES_MEM(0xe000e000, CHAM_HEADER_SIZE);

static struct resource sc31_fpga_resource = DEFINE_RES_MEM(0xf000e000, CHAM_HEADER_SIZE);



static struct platform_driver mcb_lpc_driver = {

	.driver		= {