Commit 6ef8f7da authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

devlink: don't require setting features before registration 



Requiring devlink_set_features() to be run before devlink is
registered is overzealous. devlink_set_features() itself is
a leftover from old workarounds which were trying to prevent
initiating reload before probe was complete.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9053637e

net/devlink/core.c

+0 −2
Original line number Diff line number Diff line
@@ -125,8 +125,6 @@ struct devlink *devlinks_xa_find_get(struct net *net, unsigned long *indexp) 
 */

void devlink_set_features(struct devlink *devlink, u64 features)

{

	ASSERT_DEVLINK_NOT_REGISTERED(devlink);



	WARN_ON(features & DEVLINK_F_RELOAD &&

		!devlink_reload_supported(devlink->ops));

	devlink->features = features;