Commit 6ebf23bf authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/radeon: Use regular fbdev I/O helpers 



Use the regular fbdev helpers for framebuffer I/O instead of DRM's
helpers. Radeon does not use damage handling, so DRM's fbdev helpers
are mere wrappers around the fbdev code.

By using fbdev helpers directly within each DRM fbdev emulation,
we can eventually remove DRM's wrapper functions entirely.

v4:
	* use initializer macros for struct fb_ops
v2:
	* use FB_IO_HELPERS option

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230530151228.22979-7-tzimmermann@suse.de
parent 7fca1dd9

drivers/gpu/drm/radeon/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ config DRM_RADEON 
	select DRM_SUBALLOC_HELPER

        select DRM_TTM

	select DRM_TTM_HELPER

	select FB_IO_HELPERS if DRM_FBDEV_EMULATION

	select SND_HDA_COMPONENT if SND_HDA_CORE

	select POWER_SUPPLY

	select HWMON

drivers/gpu/drm/radeon/radeon_fbdev.c

+3 −6
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 
 *     David Airlie

 */



#include <linux/fb.h>

#include <linux/pci.h>

#include <linux/pm_runtime.h>

#include <linux/vga_switcheroo.h>
@@ -190,14 +191,10 @@ static void radeon_fbdev_fb_destroy(struct fb_info *info) 


static const struct fb_ops radeon_fbdev_fb_ops = {

	.owner = THIS_MODULE,

	DRM_FB_HELPER_DEFAULT_OPS,

	.fb_open = radeon_fbdev_fb_open,

	.fb_release = radeon_fbdev_fb_release,

	.fb_read = drm_fb_helper_cfb_read,

	.fb_write = drm_fb_helper_cfb_write,

	.fb_fillrect = drm_fb_helper_cfb_fillrect,

	.fb_copyarea = drm_fb_helper_cfb_copyarea,

	.fb_imageblit = drm_fb_helper_cfb_imageblit,

	FB_DEFAULT_IO_OPS,

	DRM_FB_HELPER_DEFAULT_OPS,

	.fb_destroy = radeon_fbdev_fb_destroy,

};