Commit 6eb3cf2e authored by Nicholas Kazlauskas's avatar Nicholas Kazlauskas Committed by Alex Deucher
Browse files

drm/amd/display: Only revalidate bandwidth on medium and fast updates 

[Why]
Changes that are fast don't require updating DLG parameters making
this call unnecessary. Considering this is an expensive call it should
not be done on every flip.

DML touches clocks, p-state support, DLG params and a few other DC
internal flags and these aren't expected during fast. A hang has been
reported with this change when called on every flip which suggests that
modifying these fields is not recommended behavior on fast updates.

[How]
Guard the validation to only happen if update type isn't FAST.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1191


Fixes: a24eaa5c ("drm/amd/display: Revalidate bandwidth before commiting DC updates")
Signed-off-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarRoman Li <Roman.Li@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent 7e89e4aa

drivers/gpu/drm/amd/display/dc/core/dc.c

+6 −4
Original line number Diff line number Diff line
@@ -2538,11 +2538,13 @@ void dc_commit_updates_for_stream(struct dc *dc, 


	copy_stream_update_to_stream(dc, context, stream, stream_update);



	if (update_type > UPDATE_TYPE_FAST) {

		if (!dc->res_pool->funcs->validate_bandwidth(dc, context, false)) {

			DC_ERROR("Mode validation failed for stream update!\n");

			dc_release_state(context);

			return;

		}

	}



	commit_planes_for_stream(

				dc,