Commit 6ead9c98 authored by Shenwei Wang's avatar Shenwei Wang Committed by David S. Miller
Browse files

net: fec: remove the xdp_return_frame when lack of tx BDs 



In the implementation, the sent_frame count does not increment when
transmit errors occur. Therefore, bq_xmit_all() will take care of
returning the XDP frames.

Fixes: 26312c68 ("net: fec: correct the counting of XDP sent frames")
Signed-off-by: default avatarShenwei Wang <shenwei.wang@nxp.com>
Reviewed-by: default avatarHoratiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c83b4938

drivers/net/ethernet/freescale/fec_main.c

+0 −1
Original line number Diff line number Diff line
@@ -3798,7 +3798,6 @@ static int fec_enet_txq_xmit_frame(struct fec_enet_private *fep, 
	entries_free = fec_enet_get_free_txdesc_num(txq);

	if (entries_free < MAX_SKB_FRAGS + 1) {

		netdev_err(fep->netdev, "NOT enough BD for SG!\n");

		xdp_return_frame(frame);

		return NETDEV_TX_BUSY;

	}