Commit 6e7628c8 authored by Krzysztof Wilczyński's avatar Krzysztof Wilczyński Committed by Lorenzo Pieralisi
Browse files

PCI: microchip: Remove dev_err() when handing an error from platform_get_irq() 

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestions from Coccinelle, e.g.,
  drivers/pci/controller/pcie-microchip-host.c:1027:2-9: line 1027 is
  redundant because platform_get_irq() already prints an error

Related commit caecb05c ("PCI: Remove dev_err() when handing an
error from platform_get_irq()").

Link: https://lore.kernel.org/r/20210310131913.2802385-1-kw@linux.com


Signed-off-by: default avatarKrzysztof Wilczyński <kw@linux.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent 2c61f321

drivers/pci/controller/pcie-microchip-host.c

+1 −3
Original line number Diff line number Diff line
@@ -1023,10 +1023,8 @@ static int mc_platform_init(struct pci_config_window *cfg) 
	}



	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(dev, "unable to request IRQ%d\n", irq);

	if (irq < 0)

		return -ENODEV;

	}



	for (i = 0; i < NUM_EVENTS; i++) {

		event_irq = irq_create_mapping(port->event_domain, i);