Commit 6e5e5def authored by 蒋家盛's avatar 蒋家盛 Committed by Hans Verkuil
Browse files

media: coda: Add check for kmalloc 



As the kmalloc may return NULL pointer,
it should be better to check the return value
in order to avoid NULL poineter dereference,
same as the others.

Fixes: cb1d3a33 ("[media] coda: add CODA7541 JPEG support")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 6b808223

drivers/media/platform/chips-media/coda-bit.c

+8 −2
Original line number Diff line number Diff line
@@ -1084,10 +1084,16 @@ static int coda_start_encoding(struct coda_ctx *ctx) 
	}



	if (dst_fourcc == V4L2_PIX_FMT_JPEG) {

		if (!ctx->params.jpeg_qmat_tab[0])

		if (!ctx->params.jpeg_qmat_tab[0]) {

			ctx->params.jpeg_qmat_tab[0] = kmalloc(64, GFP_KERNEL);

		if (!ctx->params.jpeg_qmat_tab[1])

			if (!ctx->params.jpeg_qmat_tab[0])

				return -ENOMEM;

		}

		if (!ctx->params.jpeg_qmat_tab[1]) {

			ctx->params.jpeg_qmat_tab[1] = kmalloc(64, GFP_KERNEL);

			if (!ctx->params.jpeg_qmat_tab[1])

				return -ENOMEM;

		}

		coda_set_jpeg_compression_quality(ctx, ctx->params.jpeg_quality);

	}