Commit 6e4ab830 authored by Akinobu Mita's avatar Akinobu Mita Committed by Mauro Carvalho Chehab
Browse files

media: ov7740: avoid invalid framesize setting 



If the requested framesize by VIDIOC_SUBDEV_S_FMT is larger than supported
framesizes, it causes an out of bounds array access and the resulting
framesize is unexpected.

Avoid out of bounds array access and select the default framesize.

Cc: Wenyou Yang <wenyou.yang@microchip.com>
Cc: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent cfe7cc38

drivers/media/i2c/ov7740.c

+5 −1
Original line number Diff line number Diff line
@@ -785,7 +785,11 @@ static int ov7740_try_fmt_internal(struct v4l2_subdev *sd, 


		fsize++;

	}



	if (i >= ARRAY_SIZE(ov7740_framesizes)) {

		fsize = &ov7740_framesizes[0];

		fmt->width = fsize->width;

		fmt->height = fsize->height;

	}

	if (ret_frmsize != NULL)

		*ret_frmsize = fsize;