Commit 6e474e7b authored by Christophe JAILLET's avatar Christophe JAILLET Committed by liwei
Browse files

x86/signal: Fix the value returned by strict_sas_size() 

mainline inclusion
from mainline-v6.3-rc1
commit ef6dfc4b
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I9NZ3E
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef6dfc4b238a435ab552207ec09e4a82b6426d31



--------------------------------

Functions used with __setup() return 1 when the argument has been
successfully parsed.

Reverse the returned value so that 1 is returned when kstrtobool() is
successful (i.e. returns 0).

My understanding of these __setup() functions is that returning 1 or 0
does not change much anyway - so this is more of a cleanup than a
functional fix.

I spot it and found it spurious while looking at something else.
Even if the output is not perfect, you'll get the idea with:

   $ git grep -B2 -A10 retu.*kstrtobool | grep __setup -B10

Fixes: 3aac3ebe ("x86/signal: Implement sigaltstack size validation")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/73882d43ebe420c9d8fb82d0560021722b243000.1673717552.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarliwei <liwei728@huawei.com>
parent 623051c7

arch/x86/kernel/signal.c

+1 −1
Original line number Diff line number Diff line
@@ -921,7 +921,7 @@ static bool strict_sigaltstack_size __ro_after_init = false; 


static int __init strict_sas_size(char *arg)

{

	return kstrtobool(arg, &strict_sigaltstack_size);

	return kstrtobool(arg, &strict_sigaltstack_size) == 0;

}

__setup("strict_sas_size", strict_sas_size);