Commit 6e36a56a authored Apr 12, 2023 by Josh Poimboeuf Committed by Peter Zijlstra Apr 14, 2023

scsi: message: fusion: Mark mpt_halt_firmware() __noreturn



mpt_halt_firmware() doesn't return.  Mark it as such.

Fixes the following warnings:

  vmlinux.o: warning: objtool: mptscsih_abort+0x7f4: unreachable instruction
  vmlinux.o: warning: objtool: mptctl_timeout_expired+0x310: unreachable instruction

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Mark Rutland <mark.rutland@arm.com>
Debugged-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/d8129817423422355bf30e90dadc6764261b53e0.1681342859.git.jpoimboe@kernel.org

parent 52668bad

drivers/message/fusion/mptbase.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6935,7 +6935,7 @@ EXPORT_SYMBOL(mpt_clear_taskmgmt_in_progress_flag);
		* @ioc: Pointer to MPT_ADAPTER structure
		*
		**/
		void
		void __noreturn
		mpt_halt_firmware(MPT_ADAPTER *ioc)
		{
		u32 ioc_raw_state;

drivers/message/fusion/mptbase.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -945,7 +945,7 @@ extern int mpt_raid_phys_disk_get_num_paths(MPT_ADAPTER *ioc,
		u8 phys_disk_num);
		extern int mpt_set_taskmgmt_in_progress_flag(MPT_ADAPTER *ioc);
		extern void mpt_clear_taskmgmt_in_progress_flag(MPT_ADAPTER *ioc);
		extern void mpt_halt_firmware(MPT_ADAPTER *ioc);
		extern void __noreturn mpt_halt_firmware(MPT_ADAPTER *ioc);


		/*

tools/objtool/check.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -219,6 +219,7 @@ static bool __dead_end_function(struct objtool_file file, struct symbol func,
		"lbug_with_loc",
		"machine_real_restart",
		"make_task_dead",
		"mpt_halt_firmware",
		"nmi_panic_self_stop",
		"panic",
		"panic_smp_self_stop",