Unverified Commit 6e0c9b5f authored by Vinod Koul's avatar Vinod Koul Committed by Mark Brown
Browse files

ASoC: max98373: Fix return check for devm_regmap_init_sdw() 



devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on
failure which should be checked with IS_ERR. Also use PTR_ERR for
returning error codes.

Reported-by: default avatarTakashi Iwai <tiwai@suse.de>
Fixes: 56a5b791 ("ASoC: codecs: max98373: add SoundWire support")
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200826163340.3249608-2-vkoul@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d062085d

sound/soc/codecs/max98373-sdw.c

+2 −2
Original line number Diff line number Diff line
@@ -838,8 +838,8 @@ static int max98373_sdw_probe(struct sdw_slave *slave, 


	/* Regmap Initialization */

	regmap = devm_regmap_init_sdw(slave, &max98373_sdw_regmap);

	if (!regmap)

		return -EINVAL;

	if (IS_ERR(regmap))

		return PTR_ERR(regmap);



	return max98373_init(slave, regmap);

}