Commit 6dfb0771 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

HV: hv_balloon: fix memory leak with using debugfs_lookup() 



When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>
Fixes: d180e0a1 ("Drivers: hv: Create debugfs file with hyper-v balloon usage information")
Cc: stable <stable@kernel.org>
Reviewed-by: default avatarMichael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20230202140918.2289522-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 99440286

drivers/hv/hv_balloon.c

+1 −1
Original line number Diff line number Diff line
@@ -1963,7 +1963,7 @@ static void hv_balloon_debugfs_init(struct hv_dynmem_device *b) 


static void  hv_balloon_debugfs_exit(struct hv_dynmem_device *b)

{

	debugfs_remove(debugfs_lookup("hv-balloon", NULL));

	debugfs_lookup_and_remove("hv-balloon", NULL);

}



#else