Commit 6daa1da4 authored by Vinay Kumar Yadav's avatar Vinay Kumar Yadav Committed by Jakub Kicinski
Browse files

chelsio/chtls: fix memory leaks in CPL handlers 



CPL handler functions chtls_pass_open_rpl() and
chtls_close_listsrv_rpl() should return CPL_RET_BUF_DONE
so that caller function will do skb free to avoid leak.

Fixes: cc35c88a ("crypto : chtls - CPL handler definition")
Signed-off-by: default avatarVinay Kumar Yadav <vinay.yadav@chelsio.com>
Link: https://lore.kernel.org/r/20201025194228.31271-1-vinay.yadav@chelsio.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 28e9dcd9

drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c

+12 −15
Original line number Diff line number Diff line
@@ -772,14 +772,13 @@ static int chtls_pass_open_rpl(struct chtls_dev *cdev, struct sk_buff *skb) 
	if (rpl->status != CPL_ERR_NONE) {

		pr_info("Unexpected PASS_OPEN_RPL status %u for STID %u\n",

			rpl->status, stid);

		return CPL_RET_BUF_DONE;

	}

	} else {

		cxgb4_free_stid(cdev->tids, stid, listen_ctx->lsk->sk_family);

		sock_put(listen_ctx->lsk);

		kfree(listen_ctx);

		module_put(THIS_MODULE);



	return 0;

	}

	return CPL_RET_BUF_DONE;

}



static int chtls_close_listsrv_rpl(struct chtls_dev *cdev, struct sk_buff *skb)
@@ -796,15 +795,13 @@ static int chtls_close_listsrv_rpl(struct chtls_dev *cdev, struct sk_buff *skb) 
	if (rpl->status != CPL_ERR_NONE) {

		pr_info("Unexpected CLOSE_LISTSRV_RPL status %u for STID %u\n",

			rpl->status, stid);

		return CPL_RET_BUF_DONE;

	}



	} else {

		cxgb4_free_stid(cdev->tids, stid, listen_ctx->lsk->sk_family);

		sock_put(listen_ctx->lsk);

		kfree(listen_ctx);

		module_put(THIS_MODULE);



	return 0;

	}

	return CPL_RET_BUF_DONE;

}



static void chtls_purge_wr_queue(struct sock *sk)