Commit 6d99a4c0 authored by Hugh Dickins's avatar Hugh Dickins Committed by Linus Torvalds
Browse files

mm: no more EINVAL from /proc/sys/vm/stat_refresh 

EINVAL was good for drawing the refresher's attention to a warning in
dmesg, but became very tiresome when running test suites scripted with
"set -e": an underflow from a bug in one feature would cause unrelated
tests much later to fail, just because their /proc/sys/vm/stat_refresh
touch failed with that error.  Stop doing that.

Link: https://lkml.kernel.org/r/alpine.LSU.2.11.2102251510410.13363@eggly.anvils


Signed-off-by: default avatarHugh Dickins <hughd@google.com>
Acked-by: default avatarRoman Gushchin <guro@fb.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 76d8cc3c

mm/vmstat.c

+0 −5
Original line number Diff line number Diff line
@@ -1862,7 +1862,6 @@ int vmstat_refresh(struct ctl_table *table, int write, 
		if (val < 0) {

			pr_warn("%s: %s %ld\n",

				__func__, zone_stat_name(i), val);

			err = -EINVAL;

		}

	}

#ifdef CONFIG_NUMA
@@ -1871,7 +1870,6 @@ int vmstat_refresh(struct ctl_table *table, int write, 
		if (val < 0) {

			pr_warn("%s: %s %ld\n",

				__func__, numa_stat_name(i), val);

			err = -EINVAL;

		}

	}

#endif
@@ -1880,11 +1878,8 @@ int vmstat_refresh(struct ctl_table *table, int write, 
		if (val < 0) {

			pr_warn("%s: %s %ld\n",

				__func__, node_stat_name(i), val);

			err = -EINVAL;

		}

	}

	if (err)

		return err;

	if (write)

		*ppos += *lenp;

	else