Unverified Commit 6d5c9e79 authored by Alon Zahavi's avatar Alon Zahavi Committed by Konstantin Komarov
Browse files

fs/ntfs3: Fix attr_punch_hole() null pointer derenference 



The bug occours due to a misuse of `attr` variable instead of `attr_b`.
`attr` is being initialized as NULL, then being derenfernced
as `attr->res.data_size`.

This bug causes a crash of the ntfs3 driver itself,
If compiled directly to the kernel, it crashes the whole system.

Signed-off-by: default avatarAlon Zahavi <zahavi.alon@gmail.com>
Co-developed-by: default avatarTal Lossos <tallossos@gmail.com>
Signed-off-by: default avatarTal Lossos <tallossos@gmail.com>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent f27b92ec

fs/ntfs3/attrib.c

+1 −1
Original line number Diff line number Diff line
@@ -2038,7 +2038,7 @@ int attr_punch_hole(struct ntfs_inode *ni, u64 vbo, u64 bytes, u32 *frame_size) 
		return -ENOENT;



	if (!attr_b->non_res) {

		u32 data_size = le32_to_cpu(attr->res.data_size);

		u32 data_size = le32_to_cpu(attr_b->res.data_size);

		u32 from, to;



		if (vbo > data_size)