Commit 6d4e80db authored by Min Li's avatar Min Li Committed by Jens Axboe
Browse files

block: add capacity validation in bdev_add_partition() 



In the function bdev_add_partition(),there is no check that the start
and end sectors exceed the size of the disk before calling add_partition.
When we call the block's ioctl interface directly to add a partition,
and the capacity of the disk is set to 0 by driver,the command will
continue to execute.

Signed-off-by: default avatarMin Li <min15.li@samsung.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20230619091214.31615-1-min15.li@samsung.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9a72a024

block/partitions/core.c

+11 −0
Original line number Diff line number Diff line
@@ -441,10 +441,21 @@ static bool partition_overlaps(struct gendisk *disk, sector_t start, 
int bdev_add_partition(struct gendisk *disk, int partno, sector_t start,

		sector_t length)

{

	sector_t capacity = get_capacity(disk), end;

	struct block_device *part;

	int ret;



	mutex_lock(&disk->open_mutex);

	if (check_add_overflow(start, length, &end)) {

		ret = -EINVAL;

		goto out;

	}



	if (start >= capacity || end > capacity) {

		ret = -EINVAL;

		goto out;

	}



	if (!disk_live(disk)) {

		ret = -ENXIO;

		goto out;