Commit 6d473a5a authored by Daire McNamara's avatar Daire McNamara Committed by Lorenzo Pieralisi
Browse files

PCI: microchip: Correct the DED and SEC interrupt bit offsets 

The SEC and DED interrupt bits are laid out the wrong way round so the SEC
interrupt handler attempts to mask, unmask, and clear the DED interrupt
and vice versa. Correct the bit offsets so that each interrupt handler
operates properly.

Link: https://lore.kernel.org/r/20230728131401.1615724-2-daire.mcnamara@microchip.com


Fixes: 6f15a9c9 ("PCI: microchip: Add Microchip PolarFire PCIe controller driver")
Signed-off-by: default avatarDaire McNamara <daire.mcnamara@microchip.com>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
parent 06c2afb8

drivers/pci/controller/pcie-microchip-host.c

+4 −4
Original line number Diff line number Diff line
@@ -167,12 +167,12 @@ 
#define EVENT_PCIE_DLUP_EXIT			2

#define EVENT_SEC_TX_RAM_SEC_ERR		3

#define EVENT_SEC_RX_RAM_SEC_ERR		4

#define EVENT_SEC_AXI2PCIE_RAM_SEC_ERR		5

#define EVENT_SEC_PCIE2AXI_RAM_SEC_ERR		6

#define EVENT_SEC_PCIE2AXI_RAM_SEC_ERR		5

#define EVENT_SEC_AXI2PCIE_RAM_SEC_ERR		6

#define EVENT_DED_TX_RAM_DED_ERR		7

#define EVENT_DED_RX_RAM_DED_ERR		8

#define EVENT_DED_AXI2PCIE_RAM_DED_ERR		9

#define EVENT_DED_PCIE2AXI_RAM_DED_ERR		10

#define EVENT_DED_PCIE2AXI_RAM_DED_ERR		9

#define EVENT_DED_AXI2PCIE_RAM_DED_ERR		10

#define EVENT_LOCAL_DMA_END_ENGINE_0		11

#define EVENT_LOCAL_DMA_END_ENGINE_1		12

#define EVENT_LOCAL_DMA_ERROR_ENGINE_0		13