Commit 6d1aa3b0 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: Simplify ufshcd_set_dev_pwr_mode() 



Simplify the code for incrementing the SCSI device reference count in
ufshcd_set_dev_pwr_mode(). This commit removes one scsi_device_put() call
that happens from atomic context.

Reviewed-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Cc: Avri Altman <avri.altman@wdc.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20221015002418.30955-7-bvanassche@acm.org


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d460f624

drivers/ufs/core/ufshcd.c

+2 −7
Original line number Diff line number Diff line
@@ -8752,15 +8752,10 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba, 


	spin_lock_irqsave(hba->host->host_lock, flags);

	sdp = hba->ufs_device_wlun;

	if (sdp) {

	if (sdp && scsi_device_online(sdp))

		ret = scsi_device_get(sdp);

		if (!ret && !scsi_device_online(sdp)) {

			ret = -ENODEV;

			scsi_device_put(sdp);

		}

	} else {

	else

		ret = -ENODEV;

	}

	spin_unlock_irqrestore(hba->host->host_lock, flags);



	if (ret)