Commit 6cd56ef1 authored by Mel Gorman's avatar Mel Gorman Committed by Ingo Molnar
Browse files

sched/fair: Remove select_idle_smt() 



In order to make the next patch more readable, and to quantify the
actual effectiveness of this pass, start by removing it.

Signed-off-by: default avatarMel Gorman <mgorman@techsingularity.net>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Link: https://lkml.kernel.org/r/20210125085909.4600-4-mgorman@techsingularity.net
parent ed3cd45f

kernel/sched/fair.c

+0 −30
Original line number Original line Diff line number Diff line
@@ -6114,27 +6114,6 @@ static int select_idle_core(struct task_struct *p, struct sched_domain *sd, int 
	return -1;

	return -1;

}

}





/*

 * Scan the local SMT mask for idle CPUs.

 */

static int select_idle_smt(struct task_struct *p, struct sched_domain *sd, int target)

{

	int cpu;



	if (!static_branch_likely(&sched_smt_present))

		return -1;



	for_each_cpu(cpu, cpu_smt_mask(target)) {

		if (!cpumask_test_cpu(cpu, p->cpus_ptr) ||

		    !cpumask_test_cpu(cpu, sched_domain_span(sd)))

			continue;

		if (available_idle_cpu(cpu) || sched_idle_cpu(cpu))

			return cpu;

	}



	return -1;

}



#else /* CONFIG_SCHED_SMT */

#else /* CONFIG_SCHED_SMT */





static inline int select_idle_core(struct task_struct *p, struct sched_domain *sd, int target)

static inline int select_idle_core(struct task_struct *p, struct sched_domain *sd, int target)
@@ -6142,11 +6121,6 @@ static inline int select_idle_core(struct task_struct *p, struct sched_domain *s 
	return -1;

	return -1;

}

}





static inline int select_idle_smt(struct task_struct *p, struct sched_domain *sd, int target)

{

	return -1;

}



#endif /* CONFIG_SCHED_SMT */

#endif /* CONFIG_SCHED_SMT */





/*

/*
@@ -6336,10 +6310,6 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target) 
	if ((unsigned)i < nr_cpumask_bits)

	if ((unsigned)i < nr_cpumask_bits)

		return i;

		return i;





	i = select_idle_smt(p, sd, target);

	if ((unsigned)i < nr_cpumask_bits)

		return i;



	return target;

	return target;

}

}