Commit 6cc7b38c authored by Daniel Lezcano's avatar Daniel Lezcano
Browse files

thermal/drivers/cpuidle_cooling: Fix use after error 



When the function successfully finishes it logs an information about
the registration of the cooling device and use its name to build the
message. Unfortunately it was freed right before:

drivers/thermal/cpuidle_cooling.c:218 __cpuidle_cooling_register()
	warn: 'name' was already freed.

Fix this by freeing after the message happened.

Fixes: 6fd1b186 ("thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20210319202522.891061-1-daniel.lezcano@linaro.org
parent 9aa80ab2

drivers/thermal/cpuidle_cooling.c

+5 −3
Original line number Diff line number Diff line
@@ -208,18 +208,20 @@ static int __cpuidle_cooling_register(struct device_node *np, 


	cdev = thermal_of_cooling_device_register(np, name, idle_cdev,

						  &cpuidle_cooling_ops);

	kfree(name);



	if (IS_ERR(cdev)) {

		ret = PTR_ERR(cdev);

		goto out_unregister;

		goto out_kfree_name;

	}



	pr_debug("%s: Idle injection set with idle duration=%u, latency=%u\n",

		 name, idle_duration_us, latency_us);



	kfree(name);



	return 0;



out_kfree_name:

	kfree(name);

out_unregister:

	idle_inject_unregister(ii_dev);

out_kfree: