Commit 6cc385d2 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Daniel Borkmann
Browse files

selftests/bpf: Add xdp_feature selftest for bond device 



Introduce selftests to check xdp_feature support for bond driver.

Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Reviewed-by: default avatarJussi Maki <joamaki@gmail.com>
Link: https://lore.kernel.org/bpf/64cb8f20e6491f5b971f8d3129335093c359aad7.1684329998.git.lorenzo@kernel.org
parent 18f55887

tools/testing/selftests/bpf/prog_tests/xdp_bonding.c

+121 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
#include <linux/if_bonding.h>

#include <linux/limits.h>

#include <linux/udp.h>

#include <uapi/linux/netdev.h>



#include "xdp_dummy.skel.h"

#include "xdp_redirect_multi_kern.skel.h"
@@ -492,6 +493,123 @@ static void test_xdp_bonding_nested(struct skeletons *skeletons) 
	system("ip link del bond_nest2");

}



static void test_xdp_bonding_features(struct skeletons *skeletons)

{

	LIBBPF_OPTS(bpf_xdp_query_opts, query_opts);

	int bond_idx, veth1_idx, err;

	struct bpf_link *link = NULL;



	if (!ASSERT_OK(system("ip link add bond type bond"), "add bond"))

		goto out;



	bond_idx = if_nametoindex("bond");

	if (!ASSERT_GE(bond_idx, 0, "if_nametoindex bond"))

		goto out;



	/* query default xdp-feature for bond device */

	err = bpf_xdp_query(bond_idx, XDP_FLAGS_DRV_MODE, &query_opts);

	if (!ASSERT_OK(err, "bond bpf_xdp_query"))

		goto out;



	if (!ASSERT_EQ(query_opts.feature_flags, NETDEV_XDP_ACT_MASK,

		       "bond query_opts.feature_flags"))

		goto out;



	if (!ASSERT_OK(system("ip link add veth0 type veth peer name veth1"),

		       "add veth{0,1} pair"))

		goto out;



	if (!ASSERT_OK(system("ip link add veth2 type veth peer name veth3"),

		       "add veth{2,3} pair"))

		goto out;



	if (!ASSERT_OK(system("ip link set veth0 master bond"),

		       "add veth0 to master bond"))

		goto out;



	/* xdp-feature for bond device should be obtained from the single slave

	 * device (veth0)

	 */

	err = bpf_xdp_query(bond_idx, XDP_FLAGS_DRV_MODE, &query_opts);

	if (!ASSERT_OK(err, "bond bpf_xdp_query"))

		goto out;



	if (!ASSERT_EQ(query_opts.feature_flags,

		       NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |

		       NETDEV_XDP_ACT_RX_SG,

		       "bond query_opts.feature_flags"))

		goto out;



	veth1_idx = if_nametoindex("veth1");

	if (!ASSERT_GE(veth1_idx, 0, "if_nametoindex veth1"))

		goto out;



	link = bpf_program__attach_xdp(skeletons->xdp_dummy->progs.xdp_dummy_prog,

				       veth1_idx);

	if (!ASSERT_OK_PTR(link, "attach program to veth1"))

		goto out;



	/* xdp-feature for veth0 are changed */

	err = bpf_xdp_query(bond_idx, XDP_FLAGS_DRV_MODE, &query_opts);

	if (!ASSERT_OK(err, "bond bpf_xdp_query"))

		goto out;



	if (!ASSERT_EQ(query_opts.feature_flags,

		       NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |

		       NETDEV_XDP_ACT_RX_SG | NETDEV_XDP_ACT_NDO_XMIT |

		       NETDEV_XDP_ACT_NDO_XMIT_SG,

		       "bond query_opts.feature_flags"))

		goto out;



	if (!ASSERT_OK(system("ip link set veth2 master bond"),

		       "add veth2 to master bond"))

		goto out;



	err = bpf_xdp_query(bond_idx, XDP_FLAGS_DRV_MODE, &query_opts);

	if (!ASSERT_OK(err, "bond bpf_xdp_query"))

		goto out;



	/* xdp-feature for bond device should be set to the most restrict

	 * value obtained from attached slave devices (veth0 and veth2)

	 */

	if (!ASSERT_EQ(query_opts.feature_flags,

		       NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |

		       NETDEV_XDP_ACT_RX_SG,

		       "bond query_opts.feature_flags"))

		goto out;



	if (!ASSERT_OK(system("ip link set veth2 nomaster"),

		       "del veth2 to master bond"))

		goto out;



	err = bpf_xdp_query(bond_idx, XDP_FLAGS_DRV_MODE, &query_opts);

	if (!ASSERT_OK(err, "bond bpf_xdp_query"))

		goto out;



	if (!ASSERT_EQ(query_opts.feature_flags,

		       NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |

		       NETDEV_XDP_ACT_RX_SG | NETDEV_XDP_ACT_NDO_XMIT |

		       NETDEV_XDP_ACT_NDO_XMIT_SG,

		       "bond query_opts.feature_flags"))

		goto out;



	if (!ASSERT_OK(system("ip link set veth0 nomaster"),

		       "del veth0 to master bond"))

		goto out;



	err = bpf_xdp_query(bond_idx, XDP_FLAGS_DRV_MODE, &query_opts);

	if (!ASSERT_OK(err, "bond bpf_xdp_query"))

		goto out;



	ASSERT_EQ(query_opts.feature_flags, NETDEV_XDP_ACT_MASK,

		  "bond query_opts.feature_flags");

out:

	bpf_link__destroy(link);

	system("ip link del veth0");

	system("ip link del veth2");

	system("ip link del bond");

}



static int libbpf_debug_print(enum libbpf_print_level level,

			      const char *format, va_list args)

{
@@ -546,6 +664,9 @@ void serial_test_xdp_bonding(void) 
	if (test__start_subtest("xdp_bonding_nested"))

		test_xdp_bonding_nested(&skeletons);



	if (test__start_subtest("xdp_bonding_features"))

		test_xdp_bonding_features(&skeletons);



	for (i = 0; i < ARRAY_SIZE(bond_test_cases); i++) {

		struct bond_test_case *test_case = &bond_test_cases[i];