Unverified Commit 6cace797 authored by Julian Braha's avatar Julian Braha Committed by Mark Brown
Browse files

ASoC: fix unmet dependency on GPIOLIB 



When SND_SOC_SC7180 or SND_SOC_STORM is selected,
and GPIOLIB is not selected, Kbuild gives the following
warning:

WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
  Selected by [y]:
  - SND_SOC_STORM [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y]
  - SND_SOC_SC7180 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && I2C [=y]

This is because SND_SOC_MAX98357A is selected
by SND_SOC_STORM and SND_SOC_SC7180, but
these config options do not select or depend on
GPIOLIB, despite SND_SOC_MAX98357A depending on
GPIOLIB.

These unmet dependency bugs were detected by Kismet,
a static analysis tool for Kconfig. Please advise if this
is not the appropriate solution.

Signed-off-by: default avatarJulian Braha <julianbraha@gmail.com>
Link: https://lore.kernel.org/r/20211010215627.17869-1-julianbraha@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 324081ab

sound/soc/qcom/Kconfig

+2 −1
Original line number Diff line number Diff line
@@ -38,6 +38,7 @@ config SND_SOC_LPASS_SC7180 


config SND_SOC_STORM

	tristate "ASoC I2S support for Storm boards"

	depends on GPIOLIB

	select SND_SOC_LPASS_IPQ806X

	select SND_SOC_MAX98357A

	help
@@ -141,7 +142,7 @@ config SND_SOC_SM8250 


config SND_SOC_SC7180

	tristate "SoC Machine driver for SC7180 boards"

	depends on I2C

	depends on I2C && GPIOLIB

	select SND_SOC_QCOM_COMMON

	select SND_SOC_LPASS_SC7180

	select SND_SOC_MAX98357A