Commit 6caa5a2b authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Marc Zyngier
Browse files

irqchip: Fix refcount leak in platform_irqchip_probe 



of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: f8410e62 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH helper macros")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230102121318.3990586-1-linmq006@gmail.com
parent 5dc4c995

drivers/irqchip/irqchip.c

+6 −2
Original line number Diff line number Diff line
@@ -38,8 +38,10 @@ int platform_irqchip_probe(struct platform_device *pdev) 
	struct device_node *par_np = of_irq_find_parent(np);

	of_irq_init_cb_t irq_init_cb = of_device_get_match_data(&pdev->dev);



	if (!irq_init_cb)

	if (!irq_init_cb) {

		of_node_put(par_np);

		return -EINVAL;

	}



	if (par_np == np)

		par_np = NULL;
@@ -52,8 +54,10 @@ int platform_irqchip_probe(struct platform_device *pdev) 
	 * interrupt controller. The actual initialization callback of this

	 * interrupt controller can check for specific domains as necessary.

	 */

	if (par_np && !irq_find_matching_host(par_np, DOMAIN_BUS_ANY))

	if (par_np && !irq_find_matching_host(par_np, DOMAIN_BUS_ANY)) {

		of_node_put(par_np);

		return -EPROBE_DEFER;

	}



	return irq_init_cb(np, par_np);

}