Commit 6ca2ab80 authored by Tomi Valkeinen's avatar Tomi Valkeinen
Browse files

drm: automatic legacy gamma support 



To support legacy gamma ioctls the drivers need to set
drm_crtc_funcs.gamma_set either to a custom implementation or to
drm_atomic_helper_legacy_gamma_set. Most of the atomic drivers do the
latter.

We can simplify this by making the core handle it automatically.

Move the drm_atomic_helper_legacy_gamma_set() functionality into
drm_color_mgmt.c to make drm_mode_gamma_set_ioctl() use
drm_crtc_funcs.gamma_set if set or GAMMA_LUT property if not.

Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarPhilippe Cornu <philippe.cornu@st.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201211114237.213288-2-tomi.valkeinen@ti.com
parent 5c0e4110

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+0 −1
Original line number Diff line number Diff line
@@ -5452,7 +5452,6 @@ static void dm_disable_vblank(struct drm_crtc *crtc) 
static const struct drm_crtc_funcs amdgpu_dm_crtc_funcs = {

	.reset = dm_crtc_reset_state,

	.destroy = amdgpu_dm_crtc_destroy,

	.gamma_set = drm_atomic_helper_legacy_gamma_set,

	.set_config = drm_atomic_helper_set_config,

	.page_flip = drm_atomic_helper_page_flip,

	.atomic_duplicate_state = dm_crtc_duplicate_state,

drivers/gpu/drm/arm/display/komeda/komeda_crtc.c

+0 −1
Original line number Diff line number Diff line
@@ -550,7 +550,6 @@ static void komeda_crtc_vblank_disable(struct drm_crtc *crtc) 
}



static const struct drm_crtc_funcs komeda_crtc_funcs = {

	.gamma_set		= drm_atomic_helper_legacy_gamma_set,

	.destroy		= drm_crtc_cleanup,

	.set_config		= drm_atomic_helper_set_config,

	.page_flip		= drm_atomic_helper_page_flip,

drivers/gpu/drm/arm/malidp_crtc.c

+0 −1
Original line number Diff line number Diff line
@@ -510,7 +510,6 @@ static void malidp_crtc_disable_vblank(struct drm_crtc *crtc) 
}



static const struct drm_crtc_funcs malidp_crtc_funcs = {

	.gamma_set = drm_atomic_helper_legacy_gamma_set,

	.destroy = drm_crtc_cleanup,

	.set_config = drm_atomic_helper_set_config,

	.page_flip = drm_atomic_helper_page_flip,

drivers/gpu/drm/armada/armada_crtc.c

+0 −1
Original line number Diff line number Diff line
@@ -820,7 +820,6 @@ static const struct drm_crtc_funcs armada_crtc_funcs = { 
	.cursor_set	= armada_drm_crtc_cursor_set,

	.cursor_move	= armada_drm_crtc_cursor_move,

	.destroy	= armada_drm_crtc_destroy,

	.gamma_set	= drm_atomic_helper_legacy_gamma_set,

	.set_config	= drm_atomic_helper_set_config,

	.page_flip	= drm_atomic_helper_page_flip,

	.atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,

drivers/gpu/drm/ast/ast_mode.c

+0 −1
Original line number Diff line number Diff line
@@ -903,7 +903,6 @@ static void ast_crtc_atomic_destroy_state(struct drm_crtc *crtc, 


static const struct drm_crtc_funcs ast_crtc_funcs = {

	.reset = ast_crtc_reset,

	.gamma_set = drm_atomic_helper_legacy_gamma_set,

	.destroy = drm_crtc_cleanup,

	.set_config = drm_atomic_helper_set_config,

	.page_flip = drm_atomic_helper_page_flip,