Commit 6c955a9d authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: line6: Replace sprintf() with sysfs_emit() 

For sysfs outputs, it's safer to use a new helper, sysfs_emit(),
instead of the raw sprintf() & co.  This patch replaces those usages
straightforwardly with a new helper, sysfs_emit().

Link: https://lore.kernel.org/r/20220801165639.26030-8-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 17daae7a

sound/usb/line6/pod.c

+4 −4
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ static ssize_t serial_number_show(struct device *dev, 
	struct snd_card *card = dev_to_snd_card(dev);

	struct usb_line6_pod *pod = card->private_data;



	return sprintf(buf, "%u\n", pod->serial_number);

	return sysfs_emit(buf, "%u\n", pod->serial_number);

}



/*
@@ -247,7 +247,7 @@ static ssize_t firmware_version_show(struct device *dev, 
	struct snd_card *card = dev_to_snd_card(dev);

	struct usb_line6_pod *pod = card->private_data;



	return sprintf(buf, "%d.%02d\n", pod->firmware_version / 100,

	return sysfs_emit(buf, "%d.%02d\n", pod->firmware_version / 100,

			  pod->firmware_version % 100);

}
@@ -260,7 +260,7 @@ static ssize_t device_id_show(struct device *dev, 
	struct snd_card *card = dev_to_snd_card(dev);

	struct usb_line6_pod *pod = card->private_data;



	return sprintf(buf, "%d\n", pod->device_id);

	return sysfs_emit(buf, "%d\n", pod->device_id);

}



/*

sound/usb/line6/podhd.c

+2 −2
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ static ssize_t serial_number_show(struct device *dev, 
	struct snd_card *card = dev_to_snd_card(dev);

	struct usb_line6_podhd *pod = card->private_data;



	return sprintf(buf, "%u\n", pod->serial_number);

	return sysfs_emit(buf, "%u\n", pod->serial_number);

}



static ssize_t firmware_version_show(struct device *dev,
@@ -155,7 +155,7 @@ static ssize_t firmware_version_show(struct device *dev, 
	struct snd_card *card = dev_to_snd_card(dev);

	struct usb_line6_podhd *pod = card->private_data;



	return sprintf(buf, "%06x\n", pod->firmware_version);

	return sysfs_emit(buf, "%06x\n", pod->firmware_version);

}



static DEVICE_ATTR_RO(firmware_version);