Unverified Commit 6c815e29 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!5245 ceph: fix deadlock or deadcode of misusing dget() 

Merge Pull Request from: @ci-robot 
 
PR sync from: Yifan Qiao <qiaoyifan4@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/RLZVS3OAZCSN2YCIAJ5C637LGD5APVTQ/ 
 
https://gitee.com/src-openeuler/kernel/issues/I96G92 
 
Link:https://gitee.com/openeuler/kernel/pulls/5245

 

Reviewed-by: default avatarzhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parents 32bb7b0a 2d9203de

fs/ceph/caps.c

+3 −6
Original line number Diff line number Diff line
@@ -4598,12 +4598,14 @@ int ceph_encode_dentry_release(void **p, struct dentry *dentry, 
			       struct inode *dir,

			       int mds, int drop, int unless)

{

	struct dentry *parent = NULL;

	struct ceph_mds_request_release *rel = *p;

	struct ceph_dentry_info *di = ceph_dentry(dentry);

	int force = 0;

	int ret;



	/* This shouldn't happen */

	BUG_ON(!dir);



	/*

	 * force an record for the directory caps if we have a dentry lease.

	 * this is racy (can't take i_ceph_lock and d_lock together), but it
@@ -4613,14 +4615,9 @@ int ceph_encode_dentry_release(void **p, struct dentry *dentry, 
	spin_lock(&dentry->d_lock);

	if (di->lease_session && di->lease_session->s_mds == mds)

		force = 1;

	if (!dir) {

		parent = dget(dentry->d_parent);

		dir = d_inode(parent);

	}

	spin_unlock(&dentry->d_lock);



	ret = ceph_encode_inode_release(p, dir, mds, drop, unless, force);

	dput(parent);



	spin_lock(&dentry->d_lock);

	if (ret && di->lease_session && di->lease_session->s_mds == mds) {