Commit 6c79a9c8 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: dpaa2-mac: allow lynx PCS to manage mdiodev lifetime 



Put the mdiodev after lynx_pcs_create() so that the Lynx PCS driver
can manage the lifetime of the mdiodev its using.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c8cc2ae2

drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c

+1 −4
Original line number Diff line number Diff line
@@ -271,9 +271,9 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac, 
	}



	mac->pcs = lynx_pcs_create(mdiodev);

	mdio_device_put(mdiodev);

	if (!mac->pcs) {

		netdev_err(mac->net_dev, "lynx_pcs_create() failed\n");

		mdio_device_free(mdiodev);

		return -ENOMEM;

	}
@@ -285,10 +285,7 @@ static void dpaa2_pcs_destroy(struct dpaa2_mac *mac) 
	struct phylink_pcs *phylink_pcs = mac->pcs;



	if (phylink_pcs) {

		struct mdio_device *mdio = lynx_get_mdio_device(phylink_pcs);



		lynx_pcs_destroy(phylink_pcs);

		mdio_device_free(mdio);

		mac->pcs = NULL;

	}

}