Commit 6c4c900b authored by Damien Le Moal's avatar Damien Le Moal
Browse files

ata: sata_gemini: Remove dependency on OF for compile tests 



If CONFIG_OF is disabled, then using the macro of_match_ptr() results
in the gemini_sata_of_match variable being unused, which generates a
compilation warning and a compilation error if CONFIG_WERROR is enabled.

Removing the use of this macro by directly assigning the
gemini_sata_of_match match table to the .of_match_table field in the
platform driver definition allows removing the dependency on OF for
compile tests, thus improving compile test coverage.

Fixes: f7220eac ("ata: Kconfig: fix sata gemini compile test condition")
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 1dea5edc

drivers/ata/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -295,7 +295,7 @@ config SATA_FSL 


config SATA_GEMINI

	tristate "Gemini SATA bridge support"

	depends on ARCH_GEMINI || (OF && COMPILE_TEST)

	depends on ARCH_GEMINI || COMPILE_TEST

	select SATA_HOST

	default ARCH_GEMINI

	help

drivers/ata/sata_gemini.c

+1 −1
Original line number Diff line number Diff line
@@ -421,7 +421,7 @@ static const struct of_device_id gemini_sata_of_match[] = { 
static struct platform_driver gemini_sata_driver = {

	.driver = {

		.name = DRV_NAME,

		.of_match_table = of_match_ptr(gemini_sata_of_match),

		.of_match_table = gemini_sata_of_match,

	},

	.probe = gemini_sata_probe,

	.remove = gemini_sata_remove,