Commit 6c42227c authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

cec-api: prevent leaking memory through hole in structure 



Fix this smatch warning:

drivers/media/cec/core/cec-api.c:156 cec_adap_g_log_addrs() warn: check that 'log_addrs' doesn't leak information (struct has a hole after
'features')

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 13764128

drivers/media/cec/core/cec-api.c

+7 −1
Original line number Diff line number Diff line
@@ -147,7 +147,13 @@ static long cec_adap_g_log_addrs(struct cec_adapter *adap, 
	struct cec_log_addrs log_addrs;



	mutex_lock(&adap->lock);

	log_addrs = adap->log_addrs;

	/*

	 * We use memcpy here instead of assignment since there is a

	 * hole at the end of struct cec_log_addrs that an assignment

	 * might ignore. So when we do copy_to_user() we could leak

	 * one byte of memory.

	 */

	memcpy(&log_addrs, &adap->log_addrs, sizeof(log_addrs));

	if (!adap->is_configured)

		memset(log_addrs.log_addr, CEC_LOG_ADDR_INVALID,

		       sizeof(log_addrs.log_addr));