Commit 6c3e8955 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring/net: fix cleanup after recycle 



Don't access io_async_msghdr io_netmsg_recycle(), it may be reallocated.

Cc: stable@vger.kernel.org
Fixes: 9bb66906 ("io_uring: support multishot in recvmsg")
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/9e326f4ad4046ddadf15bf34bf3fa58c6372f6b5.1671461985.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 990a4de5

io_uring/net.c

+1 −1
Original line number Diff line number Diff line
@@ -820,10 +820,10 @@ int io_recvmsg(struct io_kiocb *req, unsigned int issue_flags) 
		goto retry_multishot;



	if (mshot_finished) {

		io_netmsg_recycle(req, issue_flags);

		/* fast path, check for non-NULL to avoid function call */

		if (kmsg->free_iov)

			kfree(kmsg->free_iov);

		io_netmsg_recycle(req, issue_flags);

		req->flags &= ~REQ_F_NEED_CLEANUP;

	}