Commit 6c2b74d4 authored by LABBE Corentin's avatar LABBE Corentin Committed by Herbert Xu
Browse files

crypto: sahara - check return value of sg_nents_for_len 



The sg_nents_for_len() function could fail, this patch add a check for
its return value.

Signed-off-by: default avatarLABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 8e409fe1

drivers/crypto/sahara.c

+12 −0
Original line number Diff line number Diff line
@@ -477,7 +477,15 @@ static int sahara_hw_descriptor_create(struct sahara_dev *dev) 
	}



	dev->nb_in_sg = sg_nents_for_len(dev->in_sg, dev->total);

	if (dev->nb_in_sg < 0) {

		dev_err(dev->device, "Invalid numbers of src SG.\n");

		return dev->nb_in_sg;

	}

	dev->nb_out_sg = sg_nents_for_len(dev->out_sg, dev->total);

	if (dev->nb_out_sg < 0) {

		dev_err(dev->device, "Invalid numbers of dst SG.\n");

		return dev->nb_out_sg;

	}

	if ((dev->nb_in_sg + dev->nb_out_sg) > SAHARA_MAX_HW_LINK) {

		dev_err(dev->device, "not enough hw links (%d)\n",

			dev->nb_in_sg + dev->nb_out_sg);
@@ -793,6 +801,10 @@ static int sahara_sha_hw_links_create(struct sahara_dev *dev, 
	dev->in_sg = rctx->in_sg;



	dev->nb_in_sg = sg_nents_for_len(dev->in_sg, rctx->total);

	if (dev->nb_in_sg < 0) {

		dev_err(dev->device, "Invalid numbers of src SG.\n");

		return dev->nb_in_sg;

	}

	if ((dev->nb_in_sg) > SAHARA_MAX_HW_LINK) {

		dev_err(dev->device, "not enough hw links (%d)\n",

			dev->nb_in_sg + dev->nb_out_sg);