Unverified Commit 6bfb15f3 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown
Browse files

spi: Move comment about chipselect check to the right place 



The part of the comment about locking isn't that relevant compared to
the chip select check. So drop the sentence about locking.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20211007121415.2401638-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9e1ff307

drivers/spi/spi.c

+5 −4
Original line number Diff line number Diff line
@@ -564,6 +564,11 @@ static int __spi_add_device(struct spi_device *spi) 
	struct device *dev = ctlr->dev.parent;

	int status;



	/*

	 * We need to make sure there's no other device with this

	 * chipselect **BEFORE** we call setup(), else we'll trash

	 * its configuration.

	 */

	status = bus_for_each_dev(&spi_bus_type, NULL, spi, spi_dev_check);

	if (status) {

		dev_err(dev, "chipselect %d already in use\n",
@@ -632,10 +637,6 @@ int spi_add_device(struct spi_device *spi) 
	/* Set the bus ID string */

	spi_dev_set_name(spi);



	/* We need to make sure there's no other device with this

	 * chipselect **BEFORE** we call setup(), else we'll trash

	 * its configuration.  Lock against concurrent add() calls.

	 */

	mutex_lock(&spi_add_lock);

	status = __spi_add_device(spi);

	mutex_unlock(&spi_add_lock);